Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

Default timeout is too short #239

Closed
bakhshandeh opened this issue Jan 3, 2023 · 1 comment · Fixed by #242
Closed

Default timeout is too short #239

bakhshandeh opened this issue Jan 3, 2023 · 1 comment · Fixed by #242
Assignees
@mpetrunic
Labels
released

Comments

@bakhshandeh
Copy link

We had an issue with the default configs on libp2p-js here and found that its because the default timeout is too short on js-libp2p-tcp.

I have 2 questions:
1- Is there any reason that the default timeout is too short? What's wrong with no timeout by default?

2- Is it safe to disable timeouts?
@mpetrunic mpetrunic mentioned this issue Jan 11, 2023
Merged
achingbrain pushed a commit that referenced this issue Jan 17, 2023
@mpetrunic
fix: increase default socket close timeout (#242)
a64ba41 
Increases default inactivity timeout to 5 minutes.

closes #239
github-actions bot pushed a commit that referenced this issue Jan 17, 2023
@semantic-release-bot
chore(release): 6.0.9 [skip ci]
5767c69 
## [6.0.9](v6.0.8...v6.0.9) (2023-01-17)

### Bug Fixes

* increase default socket close timeout ([#242](#242)) ([a64ba41](a64ba41)), closes [#239](#239)

### Trivial Changes

* replace err-code with CodeError ([#240](#240)) ([5c44562](5c44562)), closes [js-libp2p#1269](libp2p/js-libp2p#1269)
@github-actions
Copy link

🎉 This issue has been resolved in version 6.0.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mpetrunic mpetrunic

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: increase default socket close timeout libp2p/js-libp2p-tcp
2 participants
@bakhshandeh @mpetrunic