This repository has been archived by the owner on Apr 24, 2023. It is now read-only.
signaling server: send fresh peer list to each node every 10 seconds #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@diasdavid test added by 193a0f0 |
daviddias
approved these changes
May 19, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm building a demo using IPFS, and when testing several scenarios, IPFS was apparently unable to recover from this:
When disconnecting the network temporarily, the WebRTC peer connections disconnect shortly after. But the WS connection to the Signaling Server lingers on for a while.
Once the network is available again, each peer does not reconnect to the other known peers.
This change on the Signaling Server allows the node to get a fresh list of peers and reconnect.