This repository has been archived by the owner on Apr 24, 2023. It is now read-only.
Fix: /dns4 multiaddr explicit tcp/port support #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome PR @Steverman. 500 bonus points for description and tests! I'll figure out the WebRTC bug |
This was referenced Nov 29, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is my attempt to add explicit TCP/Port support (also my first PR ever): #129
Fixed
Not fixed
Haven't looked at
Comments
Aegir gave me problems because of WebRTC.
I'm not sure if created the test cases properly. So double check that.
Some TCP/Ports are bogus, but I don't think it's actually trying to dial them, so that's ok.
Default ports probably won't show as an explicit port by design.
Regarding /ip4, is it because of https://github.com/whyrusleeping/js-mafmt/blob/9df8d849e405ef8765e09897aba6c3c89e270572/src/index.js#L26-L34? (Just guessing)
https://github.com/whyrusleeping/js-mafmt/blob/9df8d849e405ef8765e09897aba6c3c89e270572/test/index.spec.js have a few invalid multiaddrs that is added to the "good" list (if TCP/Port must be explicit)