-
Notifications
You must be signed in to change notification settings - Fork 16
Dialling webrtc peers over webrtc-direct relay connection #171
Comments
Your listening multiaddr looks correct, could you share your JS node config along with some more info on how you are dialling that address? As I had mentioned on the referenced issue you could take a look at universal connectivity to see how we where able to dial a browser node over webRTC using webRTCDirect as a relay. |
I suspect this particular issue is something introduced since Sorry for linking these issues together as they're not really related in the end. Regarding universal connectivity, In it's current state, the webrtc connections don't continue to work after the relay is closed / after the reservation has expired. Is that the same for you? |
@DougAnderson444 saw this same behavior when he used the universal connectivity app. I created libp2p/universal-connectivity#74, this needs investigation. I believe this was working at one point but could be misremembering. In any case, it not working is a bug
Can you elaborate on your setup a bit more? is your relay node using js-libp2p? |
You're correct, good catch! Thanks for opening the PR. I will close this issue for now as we have opened another issue to investigate the issue of relays closing connections |
🎉 This issue has been resolved in version 2.0.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
It's currently not possible to dial a peer over a relayed connection established with the
/webrtc-direct
transport.For example, dialing a peer with the following multiaddr results in
CodeError: webrtc protocol was not present in multiaddr
/ip4/127.0.0.1/udp/9090/webrtc-direct/certhash/uEiBUr89tH2P9paTCPn-AcfVZcgvIvkwns96t4h55IpxFtA/p2p/12D3KooWB64sJqc3T3VCaubQCrfCvvfummrAA9z1vEXHJT77ZNJh/p2p-circuit/webrtc/p2p/12D3KooWFNBgv86tcpcYUHQz9FWGTrTmpMgr8feZwQXQySVTo3A7
The problem lies in the splitAddr function which breaks the addr up using
/webrtc
which incorrectly matches both/webrtc-direct
and/webrtc
transports.The text was updated successfully, but these errors were encountered: