Skip to content
This repository has been archived by the owner on Feb 26, 2021. It is now read-only.

fix: reduce bundle size #66

Merged
merged 2 commits into from
Jan 10, 2019
Merged

fix: reduce bundle size #66

merged 2 commits into from
Jan 10, 2019

Conversation

hugomrdias
Copy link
Member

@hugomrdias hugomrdias commented Dec 17, 2018 •
edited
Loading

249.54 180.58 -27.63484812

@ghost ghost assigned hugomrdias Dec 17, 2018
@ghost ghost added the in progress label Dec 17, 2018
@hugomrdias
Copy link
Member Author

upgrading libp2p-websocket-star-rendezvous latest 0.2.4 ❯ 0.3.0 breaks the tests

@hugomrdias
Copy link
Member Author

@jacobheun ready to merge/release

jacobheun
jacobheun approved these changes Jan 10, 2019
View reviewed changes
Copy link
Contributor

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I'll review that broken test, I think the test scenario is incorrect and recent updates to the rendezvous server expose the issue.

@jacobheun jacobheun merged commit 16b6339 into master Jan 10, 2019
@ghost ghost removed the in progress label Jan 10, 2019
@jacobheun jacobheun deleted the fix/bundle-size branch January 10, 2019 16:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jacobheun jacobheun jacobheun approved these changes

@vasco-santos vasco-santos Awaiting requested review from vasco-santos

Assignees

@hugomrdias hugomrdias

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hugomrdias @jacobheun