This repository has been archived by the owner on Jul 21, 2023. It is now read-only.
refactor: async with multiaddr conn #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
Async await changes merged but not released :( License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
vasco-santos
force-pushed
the
refactor/async-with-multiaddr-conn
branch
from
8991a3b
to
382b37a
Compare
vasco-santos
changed the title
vasco-santos
force-pushed
the
refactor/async-with-multiaddr-conn
branch
from
382b37a
to
c97a0f3
Compare
jacobheun
suggested changes
Sep 24, 2019
vasco-santos
force-pushed
the
refactor/async-with-multiaddr-conn
branch
2 times, most recently
from
d884ea6
to
227c369
Compare
jacobheun
reviewed
Sep 26, 2019
vasco-santos
force-pushed
the
refactor/async-with-multiaddr-conn
branch
from
227c369
to
a1dfb3b
Compare
vasco-santos
commented
Sep 26, 2019
vasco-santos
force-pushed
the
refactor/async-with-multiaddr-conn
branch
from
a1dfb3b
to
0a4717f
Compare
vasco-santos
force-pushed
the
refactor/async-with-multiaddr-conn
branch
from
0a4717f
to
f610735
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Switch to using async/await and async iterators. The transport and connection interfaces have changed.
Compliant with the newest ibp2p/interface-transport
Branched of #82
I added a local test for using
wssmultiaddr, which was not tested in the older version. However, I created #93 to testwssusing theinterface-transporttests in the future.Needs: