Skip to content
This repository has been archived by the owner on May 7, 2024. It is now read-only.

WebTransport multiaddr format is changing #35

Closed
achingbrain opened this issue Dec 10, 2022 · 2 comments · Fixed by #44
Closed

WebTransport multiaddr format is changing #35

achingbrain opened this issue Dec 10, 2022 · 2 comments · Fixed by #44
Assignees
@MarcoPolo
Labels
released

Comments

@achingbrain
Copy link
Member

achingbrain commented Dec 10, 2022 •
edited
Loading

Old:

/ip4/123.123.123.123/udp/2498/quic/webtransport/certhash/foo/p2p/QmBar

New:

/ip4/123.123.123.123/udp/2498/quic-v1/webtransport/certhash/foo/p2p/QmBar

The quic portion of the WebTransport multiaddr needs to be quic-v1 as quic is for QUIC draft-29 and quic-v1 is for QUIC version 1 (RFC 9000). WebTransport is not supposed to support draft-29.

Ref.
@MarcoPolo MarcoPolo self-assigned this Jan 10, 2023
@MarcoPolo
Copy link
Contributor

In the short term, maybe we allow dialing both quic and quic-v1 to support dialing older nodes.

@MarcoPolo MarcoPolo mentioned this issue Jan 11, 2023
Merged
achingbrain pushed a commit that referenced this issue Jan 12, 2023
@MarcoPolo
deps: Update deps and add quic-v1 support (#44)
d1613b1 
Fixes #35 (although I think it would have worked fine before since we never really checked quic or quic-v1 except for error cases).

Also updates the dependencies and libp2p version used in tests.
github-actions bot pushed a commit that referenced this issue Jan 12, 2023
@semantic-release-bot
chore(release): 1.0.7 [skip ci]
d077942 
## [1.0.7](v1.0.6...v1.0.7) (2023-01-12)

### Dependencies

* Update deps and add quic-v1 support ([#44](#44)) ([d1613b1](d1613b1)), closes [#35](#35)

### Documentation

* update project config to publish api docs ([#45](#45)) ([bdbf402](bdbf402))
@github-actions
Copy link

🎉 This issue has been resolved in version 1.0.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MarcoPolo MarcoPolo

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

deps: Update deps and add quic-v1 support libp2p/js-libp2p-webtransport
2 participants
@MarcoPolo @achingbrain