Skip to content
This repository has been archived by the owner on May 7, 2024. It is now read-only.

CI: Downgrade Go version #67

Closed
maschad opened this issue Apr 18, 2023 · 5 comments
Closed

CI: Downgrade Go version #67

maschad opened this issue Apr 18, 2023 · 5 comments

Comments

@maschad
Copy link
Member

maschad commented Apr 18, 2023

These failures on CI suggest that the version of quic-go bing used can't be built on Go 1.20 yet. Should we downgrade it to a compatible version?

@achingbrain
Copy link
Member

This is fixed now but it's almost certainly going to happen again.

Our options are:

  1. Update go-libp2p-daemon to the latest libp2p which will give it webtransport support, then we can use a precompiled binary and not have to build the webtransport server in this repo from source - feat: update go-libp2p to 0.27.1 go-libp2p-daemon#281
  2. Finish the node webtransport listener and remove the go parts of this repo - feat: add transport listener #31

My preference is for 2, but 1 might be faster.

@maschad
Copy link
Member Author

maschad commented Apr 28, 2023

Seeing as the go-libp2p-daemon's libp2p version is not going to be actively updated by design, I would say that we should invest the effort in 2 as well to remove it as a dependency.

@p-shahi p-shahi changed the title CI: Downgrade Go version CI: Upgrade Go version May 2, 2023
@p-shahi p-shahi changed the title CI: Upgrade Go version CI: Downgrade Go version May 2, 2023
@p-shahi
Copy link
Member

p-shahi commented May 2, 2023

closing in favor of #75

@p-shahi p-shahi closed this as completed May 2, 2023
@MarcoPolo
Copy link
Contributor

Option 3, which is the simplest, is to pin the version of Go.

@achingbrain
Copy link
Member

The reason that wasn't added as an option above is that it means adding go config to every JS repo, which didn't feel like a natural thing to do.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants