Skip to content
This repository has been archived by the owner on May 7, 2024. It is now read-only.

feat: add transport listener #31

Closed
wants to merge 6 commits into from
Closed

Conversation

achingbrain
Copy link
Member

@achingbrain achingbrain commented Nov 29, 2022

Uses @fails-components/webtransport to implement a listener for this transport in node.

Depends on:

Uses `@fails-components/webtransport` to implement a listener for
this transport in node.

Depends on:

- [ ] Removal of console.log from `@fails-components/webtransport`
- [ ] Removal of segfaults from `@fails-components/webtransport`
- [ ] Fast event loop start/stop in `@fails-components/webtransport`
- [ ] libp2p/js-libp2p#1502
@marcus-pousette
Copy link

marcus-pousette commented Feb 12, 2023

Any updates on this? Capability having a listener would help me a lot since I am only integrating with libp2p-js atm.

@p-shahi p-shahi requested a review from MarcoPolo March 7, 2023 16:33
@p-shahi
Copy link
Member

p-shahi commented Mar 15, 2023

Update on this PR: @marcus-pousette This feature is going to be added but when we ship it, it will likely be an experimental feature (since we may want to swap out the internal implementation i.e. fails-component at a later date)

There's one last PR in the fails-component/webtransport fails-components/webtransport#130 that ensures the same unit tests are run in node as well as the browser (to verify client side behaves the same). Once that's in place and a review is done, we'll be able to release this experimentally

@MarcoPolo
Copy link
Contributor

MarcoPolo commented May 22, 2023

I've removed my review request to tidy up my pending reviews, but please tag me when this is out of draft.

@dhuseby
Copy link

dhuseby commented May 7, 2024

go here: libp2p/js-libp2p#2422

@dhuseby dhuseby closed this May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants