feat: allow skipping upgrade steps for incoming connections #1502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already allow skipping upgrade steps for outgoing connections, this PR adds the same capability of incoming connections. This is to support listeners for new transports like webtransport and webrtc that manage their own encryption and multiplexing.
achingbrain
added a commit
to libp2p/js-libp2p-webtransport
that referenced
this pull request
Nov 29, 2022
Uses `@fails-components/webtransport` to implement a listener for this transport in node. Depends on: - [ ] Removal of console.log from `@fails-components/webtransport` - [ ] Removal of segfaults from `@fails-components/webtransport` - [ ] Fast event loop start/stop in `@fails-components/webtransport` - [ ] libp2p/js-libp2p#1502
6 tasks
mpetrunic
approved these changes
Nov 30, 2022
mpetrunic
deleted the
feat/allow-skipping-upgrade-steps-for-incoming-connections
branch
|
@achingbrain did you cancel checks, didn't scroll so I didn't notice some checks were cancelled? Opened #1503 in case this wasn't ready |
|
Eh, weird - no, I didn't cancel checks. |
false alarm, opened webtransport checks and got confused! |
|
Phew! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already allow skipping upgrade steps for outgoing connections, this PR adds the same capability of incoming connections.
This is to support listeners for new transports like webtransport and webrtc that manage their own encryption and multiplexing.