Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

speed of peerRouting VS contentRouting #156

Closed
florianlenz opened this issue Feb 1, 2018 · 2 comments
Closed

speed of peerRouting VS contentRouting #156

florianlenz opened this issue Feb 1, 2018 · 2 comments
Labels
exp/wizard Extensive knowledge (implications, ramifications) required kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up

Comments

@florianlenz
Copy link

  • Version: 0.15.2
  • Platform: OSX
  • Subsystem: NodeJs

Type:

Bug/Enhancement

Severity

Medium

Description:

I try to use libp2p to discover content provided by other node's in the network. The problem is that it take's more than 10 minutes to discover content provided by another node (I know that the node exist and provide that content). As as a comparison - finding that node take's only two seconds. Please have a look at the example that I provide.

Steps to reproduce the error:

  1. Clone this repo: https://github.com/Bit-Nation/group-chat-poc
  2. Checkout commit 96d9b013929d1f57b7ae30c5d67d4c843537b5f8
  3. Run npm install
  4. Start the provider node provide.js and wait a few seconds for the node to dial to peers
  5. Start the node that look's for the content by running node chat.js
  6. Wait till you see the timeout error (should appear after 10 minutes).
@florianlenz florianlenz changed the title speed of peerDiscovery Vs content discovery speed of peer discovery Vs content discovery Feb 1, 2018
@florianlenz florianlenz changed the title speed of peer discovery Vs content discovery speed of peer discovery VS content discovery Feb 2, 2018
@daviddias daviddias added the status/ready Ready to be worked label Feb 5, 2018
@daviddias
Copy link
Member

Hi @florianlenz thanks for the report. Seems that the bug is coming from https://github.com/libp2p/js-libp2p-kad-dht, still experimental. Do you think you can add a failing test there that would enable us to track down the issue? Thanks!

@daviddias daviddias added kind/bug A bug in existing code (including security flaws) exp/wizard Extensive knowledge (implications, ramifications) required P1 High: Likely tackled by core team if no one steps up labels Feb 20, 2018
@daviddias daviddias changed the title speed of peer discovery VS content discovery speed of peerRouting VS contentRouting Feb 20, 2018
@jacobheun
Copy link
Contributor

Closing this due to inactivity. The current content and peer routing example https://github.com/libp2p/js-libp2p/tree/master/examples/peer-and-content-routing is returning those calls. The original code linked in the issue doesn't look like it was enabled the dht, which would cause the issue.

If you're still having issues, please feel free to reopen this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exp/wizard Extensive knowledge (implications, ramifications) required kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up
Projects
None yet
Development

No branches or pull requests

3 participants