Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(protocol/perf): consider using tls or noise instead of plaintext #1991

Closed
mxinden opened this issue Aug 25, 2023 · 0 comments · Fixed by #1992
Closed

fix(protocol/perf): consider using tls or noise instead of plaintext #1991

mxinden opened this issue Aug 25, 2023 · 0 comments · Fixed by #1992

Comments

@mxinden
Copy link
Member

mxinden commented Aug 25, 2023

All other libp2p perf protocol implementations use some mechanism of encryption. For a better comparison, consider using TLS or Noise in the js-libp2p perf implementation as well.

js-libp2p/packages/protocol-perf/src/main.ts

Lines 59 to 61 in 8977862

connectionEncryption: [
plaintext()
],

//CC @maschad

Related pull request adding js-libp2p to libp2p/test-plans/perf libp2p/test-plans#244.
maschad added a commit to maschad/js-libp2p that referenced this issue Aug 25, 2023
@maschad
feat(@libp2p/protocol-perf): use noise for encryption (libp2p#1991)
9c6fe7b
@maschad maschad mentioned this issue Aug 25, 2023
Merged
achingbrain pushed a commit that referenced this issue Aug 25, 2023
@maschad
fix(@libp2p/protocol-perf): use noise for encryption (#1992)
24c1c24 
Closes #1991
@maschad maschad mentioned this issue Aug 25, 2023
Closed
This was referenced Sep 6, 2023
Closed
Merged
This was referenced Jan 18, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@mxinden