Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update dht #1009

Merged
merged 25 commits into from
Nov 25, 2021
Merged

feat: update dht #1009

merged 25 commits into from
Nov 25, 2021

Conversation

achingbrain
Copy link
Member

@achingbrain achingbrain commented Oct 12, 2021 •
edited
Loading

@achingbrain
feat: update dht
2188efe 
Changes dht creation to use factory function.
vasco-santos
vasco-santos reviewed Oct 18, 2021
View reviewed changes
Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool! we also need to update the docs like CONFIGURATION.md file to reflect this

@achingbrain achingbrain mentioned this pull request Nov 18, 2021
Merged
2 tasks
@achingbrain achingbrain marked this pull request as ready for review November 18, 2021 19:03
This was referenced Nov 22, 2021
Merged
Merged
@achingbrain
Copy link
Member Author

This has been rolled up to js-ipfs here: ipfs/js-ipfs#3947

@achingbrain achingbrain merged commit 2f598eb into master Nov 25, 2021
@achingbrain achingbrain deleted the feat/update-dht branch November 25, 2021 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vasco-santos vasco-santos vasco-santos left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@achingbrain @vasco-santos