feat: allow per-component metrics to be collected #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements the idea from #1060 - allows us to get some insight into what's happening in a libp2p node out side of just bandwidth stats.
Closed
achingbrain
added a commit
to ipfs/js-ipfs
that referenced
this pull request
Dec 15, 2021
Exposes the per-component metrics from libp2p/js-libp2p#1061 in the prometheus end point. Also allows changing the `debug` logging level dynamically.
achingbrain
added a commit
to ipfs/js-ipfs
that referenced
this pull request
Dec 15, 2021
Exposes the per-component metrics from libp2p/js-libp2p#1061 in the prometheus end point. Also allows changing the `debug` logging level dynamically.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the idea from #1060 - allows us to get some insight into what's happening in a libp2p node out side of just bandwidth stats.
Configures a few default metrics if metrics are enabled - current connections, the state of the dial queue, etc.
Also makes the
Metricsclass not depend on theConnectionManagerclass, otherwise we can't collect simple metrics from the connection manager class due to the circular dependency.