feat: constrain stream counts by protocol on a per-connection basis #1239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a config key `connectionManager.protocolStreamLimits` that lets users define `protocol` -> `maxCount` mappings to limit the number of multiplexed streams that can be opened simultaneously on a per- connection basis. Applies to both incoming and outgoing streams.
|
A nicer API might be to have the registrar accept some additional config when you register a stream handler and would include the number of concurrent streams. It'd mean the config wouldn't need to know about all protocols at startup time. |
|
Interfaces change to support configuring stream limits when you register a handler: libp2p/js-libp2p-interfaces#225 |
wemeetagain
approved these changes
Jun 12, 2022
|
Superseded by #1255 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a config key
connectionManager.protocolStreamLimitsthat lets users defineprotocol->maxCountmappings to limit the number of multiplexed streams that can be opened simultaneously on a per-connection basis.Applies to both incoming and outgoing streams.
The config key is passed to the upgrader internally because a) we don't expose upgrader config and b) longer term we want to move the upgrader's responsibilities around connection/stream management into the connection manager.