fix: registrar is not calling topology on peer reconnect #1504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like regression as it was once fixed in same manner: https://github.com/libp2p/js-libp2p-interfaces/pull/54/files |
achingbrain
approved these changes
Dec 1, 2022
|
Thanks for the fix, hope new npm version will be released soon. |
|
Likely Monday morning - in the interim you can test with the rc with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the peer reconnects with the same protocols,
change:protocolsis not emitted and topologyonConnectcallbacks are not invoked. This adds listening to connect events in the registrar and checks if we already know protocols for peers before calling the topologyonConnectcallback.resolves #1496