[WIP] feat: use pull stream based mplex #192
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Tests are also failing against master - #191, it doesn't seem to be related to the mplex changes. |
dryajov
changed the title
This was referenced May 9, 2018
daviddias
reviewed
May 12, 2018
| .switch | ||
| .transports[Circuit.tag] | ||
| .listeners[0] | ||
| .hopHandler, 'handle')) |
There was a problem hiding this comment.
Just formating, can be removed.
daviddias
reviewed
May 12, 2018
| @@ -40,7 +40,7 @@ | |||
| "async": "^2.6.0", | |||
| "libp2p-floodsub": "^0.15.0", | |||
| "libp2p-ping": "~0.8.0", | |||
| "libp2p-switch": "~0.39.2", | |||
| "libp2p-switch": "libp2p/js-libp2p-switch#feat/pull-mplex", | |||
There was a problem hiding this comment.
The only change should happen https://github.com/libp2p/js-libp2p-mplex
There was a problem hiding this comment.
This is just to run it on CI. Should be closed once libp2p-mplex is merged.
dryajov
changed the title
|
Work on libp2p/js-libp2p-mplex#76 |
maschad
pushed a commit
to maschad/js-libp2p
that referenced
this pull request
Jun 21, 2023
Bumps [it-take](https://github.com/achingbrain/it) from 1.0.2 to 2.0.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/achingbrain/it/releases">it-take's releases</a>.</em></p> <blockquote> <h2>it-take-v2.0.0</h2> <h2><a href="https://github.com/achingbrain/it/compare/it-take-v1.0.2...it-take-v2.0.0">it-take-v2.0.0</a> (2022-10-17)</h2> <h3>⚠ BREAKING CHANGES</h3> <ul> <li>all modules are now published as ESM-only</li> </ul> <h3>Features</h3> <ul> <li>convert to typescript (<a href="https://github-redirect.dependabot.com/achingbrain/it/issues/28">#28</a>) (<a href="https://github.com/achingbrain/it/commit/f8a38bfb1b902e8101f1077eb33c3cea49819464">f8a38bf</a>)</li> </ul> <h3>Dependencies</h3> <ul> <li>update sibling dependencies (<a href="https://github.com/achingbrain/it/commit/1415cdd019f32c08b1024e60bf3816619e361938">1415cdd</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/achingbrain/it/commit/f4858cf2bc19ae9dad28d42fa63ad36bd1547424"><code>f4858cf</code></a> chore(release): 2.0.0 [skip ci]</li> <li><a href="https://github.com/achingbrain/it/commit/49ba7cddc6e86fdbff3ac85f73f51fa829b63162"><code>49ba7cd</code></a> chore(release): 2.0.0 [skip ci]</li> <li><a href="https://github.com/achingbrain/it/commit/4bd3de6a1768ec8c2aef4e69a6ebd6930a9e372a"><code>4bd3de6</code></a> chore(release): 2.0.0 [skip ci]</li> <li><a href="https://github.com/achingbrain/it/commit/902a21b698b922b020817af27259fa3ba41128f7"><code>902a21b</code></a> chore(release): 2.0.0 [skip ci]</li> <li><a href="https://github.com/achingbrain/it/commit/7bbd587d63e85474540da69de75825183f1807b8"><code>7bbd587</code></a> chore(release): 2.0.0 [skip ci]</li> <li><a href="https://github.com/achingbrain/it/commit/57e9c07fe00e6f09533e51e5df9b33b9a88d7c8e"><code>57e9c07</code></a> chore(release): 3.0.0 [skip ci]</li> <li><a href="https://github.com/achingbrain/it/commit/43c7be2edd414dd574470cbc886ae08467227ef2"><code>43c7be2</code></a> chore(release): 1.0.0 [skip ci]</li> <li><a href="https://github.com/achingbrain/it/commit/7aa6d9bb9045c2fb6d6452538796dfabe8698d92"><code>7aa6d9b</code></a> chore(release): 2.0.0 [skip ci]</li> <li><a href="https://github.com/achingbrain/it/commit/790aae9d03b91baa82c783769de649fc1706b562"><code>790aae9</code></a> chore(release): 2.0.0 [skip ci]</li> <li><a href="https://github.com/achingbrain/it/commit/80da857e2badaf7f4014c96853bcb2a7830e6032"><code>80da857</code></a> chore: remove clean from it-glob as aegir depends on it</li> <li>Additional commits viewable in <a href="https://github.com/achingbrain/it/compare/it-take@1.0.2...it-take-v2.0.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
maschad
pushed a commit
to maschad/js-libp2p
that referenced
this pull request
Jun 21, 2023
## [5.0.1](libp2p/js-libp2p-websockets@v5.0.0...v5.0.1) (2022-12-08) ### Bug Fixes * cannot catch EADDRINUSE ([libp2p#198](libp2p/js-libp2p-websockets#198)) ([c7312db](libp2p/js-libp2p-websockets@c7312db)), closes [libp2p#184](libp2p/js-libp2p-websockets#184) ### Dependencies * **dev:** bump @libp2p/interface-mocks from 7.1.0 to 8.0.2 ([libp2p#199](libp2p/js-libp2p-websockets#199)) ([daff533](libp2p/js-libp2p-websockets@daff533)), closes [libp2p#318](https://github.com/libp2p/js-libp2p-websockets/issues/318) [libp2p#315](https://github.com/libp2p/js-libp2p-websockets/issues/315) [libp2p#313](https://github.com/libp2p/js-libp2p-websockets/issues/313) [libp2p#312](https://github.com/libp2p/js-libp2p-websockets/issues/312) * **dev:** bump it-all from 1.0.6 to 2.0.0 ([libp2p#193](libp2p/js-libp2p-websockets#193)) ([6213f8f](libp2p/js-libp2p-websockets@6213f8f)), closes [libp2p#28](libp2p/js-libp2p-websockets#28) [libp2p#28](libp2p/js-libp2p-websockets#28) [libp2p#27](libp2p/js-libp2p-websockets#27) [libp2p#24](libp2p/js-libp2p-websockets#24) * **dev:** bump it-drain from 1.0.5 to 2.0.0 ([libp2p#191](libp2p/js-libp2p-websockets#191)) ([e549691](libp2p/js-libp2p-websockets@e549691)), closes [libp2p#28](libp2p/js-libp2p-websockets#28) [libp2p#28](libp2p/js-libp2p-websockets#28) [libp2p#27](libp2p/js-libp2p-websockets#27) [libp2p#24](libp2p/js-libp2p-websockets#24) * **dev:** bump it-take from 1.0.2 to 2.0.0 ([libp2p#192](libp2p/js-libp2p-websockets#192)) ([4c037fc](libp2p/js-libp2p-websockets@4c037fc)), closes [libp2p#28](libp2p/js-libp2p-websockets#28)
maschad
pushed a commit
to maschad/js-libp2p
that referenced
this pull request
Jun 21, 2023
The libp2p address manager does this so we can just treat the addresses as opaque values here. Fixes libp2p#1673
maschad
pushed a commit
to maschad/js-libp2p
that referenced
this pull request
Jun 21, 2023
## [7.0.3](libp2p/js-libp2p-mdns@v7.0.2...v7.0.3) (2023-04-07) ### Bug Fixes * do not append peer id to advertised addresses ([libp2p#192](libp2p/js-libp2p-mdns#192)) ([d1ee623](libp2p/js-libp2p-mdns@d1ee623))
achingbrain
added a commit
that referenced
this pull request
Jun 27, 2023
`@libp2p/components` is a choke-point for our dependency graph as it depends on every interface, meaning when one interface revs a major `@libp2p/components` major has to change too which means every module depending on it also needs a major. Switch instead to constructor injection of simple objects that let modules declare their dependencies on interfaces directly instead of indirectly via `@libp2p/components` Refs libp2p/js-libp2p-components#6 BREAKING CHANGE: modules no longer implement `Initializable` instead switching to constructor injection
achingbrain
pushed a commit
that referenced
this pull request
Jun 27, 2023
## [5.0.0](libp2p/js-libp2p-floodsub@v4.0.1...v5.0.0) (2022-10-12) ### ⚠ BREAKING CHANGES * modules no longer implement `Initializable` instead switching to constructor injection ### Bug Fixes * remove @libp2p/components ([#192](libp2p/js-libp2p-floodsub#192)) ([9916896](libp2p/js-libp2p-floodsub@9916896)), closes [libp2p/js-libp2p-components#6](libp2p/js-libp2p-components#6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Im using libp2p-switch as a git dep, so that we can test it on CI. This is temporary and should be changed once libp2p-switch is released.