Add ability to pass a connection protector for private networking #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
jacobheun
force-pushed
the
feat/priv-net
branch
4 times, most recently
from
94404e8 to
dea17c7
Compare
fix: update protector config and tests docs: add private network info to the readme test: fix an issue with config
daviddias
reviewed
Jul 19, 2018
| @@ -135,6 +136,7 @@ class Node extends libp2p { | |||
| connEncryption: [ | |||
| SECIO | |||
| ], | |||
| connProtector: new Protector(/*protector specific opts*/), | |||
There was a problem hiding this comment.
Do we want to have multiple Protectors or just just have it inside and enable it as a config value?
There was a problem hiding this comment.
The implementation is based off of go which just supports a single, configurable protector. Users will be able to supply any protector they want, so it's extendable in the future as more protectors are created. In theory we could turn it into a list of protectors but I can't think of a use case where you'd want to do that as multiple levels of encryption on top of secio is really expensive.
If we produce more "intelligent" protectors in the future, those would be easy to swap out.
daviddias
approved these changes
Jul 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to specify a connection protector (private networking) via the new libp2p configuration. Once libp2p/js-libp2p-pnet#1 is released, we will be able to add that as a protector, such as through js-ipfs.
This will require an update to the libp2p-switch version once js-libp2p-switch#266 is released.