fix!: remove dialler language #2143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wemeetagain I've targeted the v1 release branch - please can you add some copy to the migration guide to cover these breaking changes. |
Closed
|
ready for re-review |
|
Would like to merge this first to avoid conflicts around adding a migration doc |
|
Maybe open a PR with all the migration doc changes? That would avoid conflicts? |
maschad
requested changes
Oct 10, 2023
It may be hard to ensure all the changes are encompassed in the migration doc if it's a substantial diff. It would be better to do it per PR. |
Co-authored-by: Chad Nehemiah <chad.nehemiah94@gmail.com>
maschad
approved these changes
Oct 11, 2023
|
This PR has added a |
|
Oops |
achingbrain
added a commit
that referenced
this pull request
Oct 31, 2023
Co-authored-by: Chad Nehemiah <chad.nehemiah94@gmail.com> Co-authored-by: Cayman <caymannava@gmail.com>
achingbrain
added a commit
that referenced
this pull request
Nov 3, 2023
Co-authored-by: Chad Nehemiah <chad.nehemiah94@gmail.com> Co-authored-by: Cayman <caymannava@gmail.com>
achingbrain
added a commit
that referenced
this pull request
Nov 7, 2023
Co-authored-by: Chad Nehemiah <chad.nehemiah94@gmail.com> Co-authored-by: Cayman <caymannava@gmail.com>
achingbrain
added a commit
that referenced
this pull request
Nov 8, 2023
Co-authored-by: Chad Nehemiah <chad.nehemiah94@gmail.com> Co-authored-by: Cayman <caymannava@gmail.com>
achingbrain
added a commit
that referenced
this pull request
Nov 10, 2023
Co-authored-by: Chad Nehemiah <chad.nehemiah94@gmail.com> Co-authored-by: Cayman <caymannava@gmail.com>
maschad
added a commit
to maschad/js-libp2p
that referenced
this pull request
Nov 10, 2023
Co-authored-by: Chad Nehemiah <chad.nehemiah94@gmail.com> Co-authored-by: Cayman <caymannava@gmail.com>
achingbrain
added a commit
that referenced
this pull request
Nov 15, 2023
Co-authored-by: Chad Nehemiah <chad.nehemiah94@gmail.com> Co-authored-by: Cayman <caymannava@gmail.com>
This was referenced Nov 15, 2023
Closed
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description