fix!: remove min/max from topologies #2158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Once upon a time these options were intended to cause libp2p to close connections or search for more peers that support a given protocol but it was never implemented. Remove the options since they don't do anything, they may be restored in future if the functionality is ever required.
wemeetagain
approved these changes
Oct 13, 2023
achingbrain
added a commit
that referenced
this pull request
Oct 31, 2023
Once upon a time these options were intended to cause libp2p to close connections or search for more peers that support a given protocol but it was never implemented. Remove the options since they don't do anything, they may be restored in future if the functionality is ever required.
achingbrain
added a commit
that referenced
this pull request
Nov 3, 2023
Once upon a time these options were intended to cause libp2p to close connections or search for more peers that support a given protocol but it was never implemented. Remove the options since they don't do anything, they may be restored in future if the functionality is ever required.
achingbrain
added a commit
that referenced
this pull request
Nov 7, 2023
Once upon a time these options were intended to cause libp2p to close connections or search for more peers that support a given protocol but it was never implemented. Remove the options since they don't do anything, they may be restored in future if the functionality is ever required.
achingbrain
added a commit
that referenced
this pull request
Nov 8, 2023
Once upon a time these options were intended to cause libp2p to close connections or search for more peers that support a given protocol but it was never implemented. Remove the options since they don't do anything, they may be restored in future if the functionality is ever required.
achingbrain
added a commit
that referenced
this pull request
Nov 10, 2023
Once upon a time these options were intended to cause libp2p to close connections or search for more peers that support a given protocol but it was never implemented. Remove the options since they don't do anything, they may be restored in future if the functionality is ever required.
maschad
pushed a commit
to maschad/js-libp2p
that referenced
this pull request
Nov 10, 2023
Once upon a time these options were intended to cause libp2p to close connections or search for more peers that support a given protocol but it was never implemented. Remove the options since they don't do anything, they may be restored in future if the functionality is ever required.
achingbrain
added a commit
that referenced
this pull request
Nov 15, 2023
Once upon a time these options were intended to cause libp2p to close connections or search for more peers that support a given protocol but it was never implemented. Remove the options since they don't do anything, they may be restored in future if the functionality is ever required.
This was referenced Nov 15, 2023
Closed
Merged
Closed
This was referenced Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once upon a time these options were intended to cause libp2p to close connections or search for more peers that support a given protocol but it was never implemented.
Remove the options since they don't do anything, they may be restored in future if the functionality is ever required.
Change checklist