chore: fix ping tests #2215
Merged
chore: fix ping tests #2215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ping tests run over transient connections which can hit relay limits. Instead listen on tcp connections so the tests only run over direct connections.
achingbrain
force-pushed
the
fix/ping-tests
branch
from
bd40d59
to
ccc4784
Compare
maschad
approved these changes
Nov 7, 2023
maschad
pushed a commit
to maschad/js-libp2p
that referenced
this pull request
Nov 10, 2023
The ping tests run over transient connections which can hit relay limits. Instead listen on tcp connections so the tests only run over direct connections.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ping tests run over transient connections which can hit relay limits.
Instead listen on tcp connections so the tests only run over direct connections.
Change checklist