Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable publishing with npm provenance #2247

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

achingbrain
Copy link
Member

Adds config to publish npm packages with links back to the build that generated the artefacts.

https://github.blog/2023-04-19-introducing-npm-package-provenance/

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@achingbrain achingbrain requested a review from a team as a code owner November 20, 2023 16:21
@maschad
Copy link
Member

maschad commented Nov 20, 2023

CI isn't too happy looks like #2246 broke it?

@achingbrain
Copy link
Member Author

CI passed on #2246 so I don't think so?

@maschad
Copy link
Member

maschad commented Nov 20, 2023

Yah that was a strange CI fluke not sure where that other error could have come from.

@achingbrain achingbrain marked this pull request as draft November 21, 2023 08:20
@achingbrain
Copy link
Member Author

Not for merging yet - I want to get it publishing RCs with provenance first which will need further changes elsewhere.

@achingbrain achingbrain marked this pull request as ready for review November 27, 2023 18:36
@achingbrain
Copy link
Member Author

Looks like the simplest thing to do might be to use publishConfig.

@achingbrain achingbrain merged commit 68db79f into main Nov 27, 2023
21 checks passed
@achingbrain achingbrain deleted the chore/enable-npm-provenance branch November 27, 2023 18:37
@achingbrain
Copy link
Member Author

maschad pushed a commit to maschad/js-libp2p that referenced this pull request Nov 27, 2023
Adds config to publish npm packages with links back to the build
that generated the artefacts.

https://github.blog/2023-04-19-introducing-npm-package-provenance/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants