docs: fix example in README #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The JSON in the example was missing some commas.
ghost
assigned 
maschad
pushed a commit
to maschad/js-libp2p
that referenced
this pull request
Jun 21, 2023
* fix: yield single buffers Messages are serialized to multiple buffers, intsead of yield each buffer one by one, create single buffers that contain the whole serialized message. This greatly improves transport performance as writing one big buffer is a lot faster than writing lots of small buffers to network sockets etc. Before: ``` testing 0.40.x-mplex sender 3276811 messages 17 invocations sender 6553636 bufs 17 b 24197 ms 105 MB in 32 B chunks in 24170ms ``` After: ``` testing 0.40.x-mplex sender 3276811 messages 1638408 invocations 1638411 bufs 68 b 8626 ms 105 MB in 32 B chunks in 8611ms ``` * chore: update comment
maschad
pushed a commit
to maschad/js-libp2p
that referenced
this pull request
Jun 21, 2023
## [7.0.5](libp2p/js-libp2p-mplex@v7.0.4...v7.0.5) (2022-11-24) ### Bug Fixes * apply message size limit before decoding message ([libp2p#231](libp2p/js-libp2p-mplex#231)) ([279ad47](libp2p/js-libp2p-mplex@279ad47)) * limit unprocessed message queue size separately to message size ([libp2p#234](libp2p/js-libp2p-mplex#234)) ([2297856](libp2p/js-libp2p-mplex@2297856)) * yield single buffers ([libp2p#233](libp2p/js-libp2p-mplex#233)) ([31d3938](libp2p/js-libp2p-mplex@31d3938))
maschad
pushed a commit
to maschad/js-libp2p
that referenced
this pull request
Jun 21, 2023
Bumps [sinon](https://github.com/sinonjs/sinon) from 14.0.2 to 15.0.0. - [Release notes](https://github.com/sinonjs/sinon/releases) - [Changelog](https://github.com/sinonjs/sinon/blob/main/docs/changelog.md) - [Commits](sinonjs/sinon@v14.0.2...v15.0.0) --- updated-dependencies: - dependency-name: sinon dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
maschad
pushed a commit
to maschad/js-libp2p
that referenced
this pull request
Jun 21, 2023
## [6.0.5](libp2p/js-libp2p-tcp@v6.0.4...v6.0.5) (2022-12-06) ### Dependencies * **dev:** bump sinon from 14.0.2 to 15.0.0 ([libp2p#233](libp2p/js-libp2p-tcp#233)) ([72a79ab](libp2p/js-libp2p-tcp@72a79ab))
maschad
pushed a commit
to maschad/js-libp2p
that referenced
this pull request
Jun 21, 2023
* deps: bump @libp2p/interface-transport from 3.0.0 to 4.0.0 Bumps [@libp2p/interface-transport](https://github.com/libp2p/js-libp2p-interfaces) from 3.0.0 to 4.0.0. - [Release notes](https://github.com/libp2p/js-libp2p-interfaces/releases) - [Commits](https://github.com/libp2p/js-libp2p-interfaces/compare/@libp2p/interface-transport-v3.0.0...@libp2p/interface-transport-v4.0.0) --- updated-dependencies: - dependency-name: "@libp2p/interface-transport" dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * deps(dev): bump @libp2p/interface-mocks from 10.0.3 to 11.0.0 Bumps [@libp2p/interface-mocks](https://github.com/libp2p/js-libp2p-interfaces) from 10.0.3 to 11.0.0. - [Release notes](https://github.com/libp2p/js-libp2p-interfaces/releases) - [Commits](https://github.com/libp2p/js-libp2p-interfaces/compare/@libp2p/interface-mocks-v10.0.3...@libp2p/interface-mocks-v11.0.0) --- updated-dependencies: - dependency-name: "@libp2p/interface-mocks" dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * deps(dev): bump @libp2p/interface-transport-compliance-tests Bumps [@libp2p/interface-transport-compliance-tests](https://github.com/libp2p/js-libp2p-interfaces) from 3.0.13 to 4.0.0. - [Release notes](https://github.com/libp2p/js-libp2p-interfaces/releases) - [Commits](https://github.com/libp2p/js-libp2p-interfaces/compare/@libp2p/interface-transport-compliance-tests-v3.0.13...@libp2p/interface-transport-compliance-tests-v4.0.0) --- updated-dependencies: - dependency-name: "@libp2p/interface-transport-compliance-tests" dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: achingbrain <alex@achingbrain.net>
maschad
pushed a commit
to maschad/js-libp2p
that referenced
this pull request
Jun 21, 2023
## [6.0.1](libp2p/js-libp2p-websockets@v6.0.0...v6.0.1) (2023-04-24) ### Dependencies * bump @libp2p/interface-transport from 3.0.0 to 4.0.0 ([libp2p#233](libp2p/js-libp2p-websockets#233)) ([da0367f](libp2p/js-libp2p-websockets@da0367f))
achingbrain
added a commit
that referenced
this pull request
Jun 27, 2023
* deps(dev): bump aegir from 38.1.8 to 39.0.10 Bumps [aegir](https://github.com/ipfs/aegir) from 38.1.8 to 39.0.10. - [Release notes](https://github.com/ipfs/aegir/releases) - [Changelog](https://github.com/ipfs/aegir/blob/master/CHANGELOG.md) - [Commits](ipfs/aegir@v38.1.8...v39.0.10) --- updated-dependencies: - dependency-name: aegir dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * chore: update linting * chore: add missing dep * chore: update deps --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: achingbrain <alex@achingbrain.net>
achingbrain
pushed a commit
that referenced
this pull request
Jun 27, 2023
## [7.0.2](libp2p/js-libp2p-floodsub@v7.0.1...v7.0.2) (2023-06-27) ### Trivial Changes * Update .github/workflows/semantic-pull-request.yml [skip ci] ([3e98edd](libp2p/js-libp2p-floodsub@3e98edd)) * Update .github/workflows/stale.yml [skip ci] ([95c7400](libp2p/js-libp2p-floodsub@95c7400)) ### Dependencies * **dev:** bump aegir from 38.1.8 to 39.0.10 ([#233](libp2p/js-libp2p-floodsub#233)) ([e073298](libp2p/js-libp2p-floodsub@e073298))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JSON in the example was missing some commas.