Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: silence max listeners warning #2417

Merged
merged 2 commits into from
Feb 19, 2024
Merged

Conversation

achingbrain
Copy link
Member

When recreating the dial queue shutdown controller, we must also increase the number of listeners it can have, otherwise warnings are printed when there are more than 10 peers in the dial queue.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

When recreating the dial queue shutdown controller, we must also
increase the number of listeners it can have, otherwise warnings
are printed when there are more than 10 peers in the dial queue.
@achingbrain achingbrain force-pushed the fix/max-listeners-warning branch from 6719b40 to ab9dec5 Compare February 19, 2024 13:19
@achingbrain achingbrain merged commit bedfd0a into main Feb 19, 2024
22 checks passed
@achingbrain achingbrain deleted the fix/max-listeners-warning branch February 19, 2024 15:41
@achingbrain achingbrain mentioned this pull request Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant