Update deps and fix non deterministic browser test #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test: remove unneeded test timeout
ghost
assigned 
vasco-santos
approved these changes
Sep 24, 2018
maschad
pushed a commit
to maschad/js-libp2p
that referenced
this pull request
Jun 21, 2023
maschad
pushed a commit
to maschad/js-libp2p
that referenced
this pull request
Jun 21, 2023
Co-authored-by: web3-bot <web3-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The webrtc browser tests were not properly checking for the expected peer, just a number of connections, and were trying to do so based on an order of peer discovery events. If other peers on the jenkins network connect to the discovery service, this will make the tests fail.
The tests now check for connections with the expected peer id and complete the test once it's present. Due to this, the timeout is also not needed, as the discovery happens within a few hundred ms.