Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add datastore to config #270

Merged
merged 1 commit into from
Oct 31, 2018
Merged

Conversation

vasco-santos
Copy link
Member

In the context of the awesome endeavour for enabling the DHT by default in js-ipfs, libp2p must receive an option with a datastore to be used js-ipfs#856#issuecomment-434601550

@ghost ghost assigned vasco-santos Oct 31, 2018
@ghost ghost added the status/in-progress In progress label Oct 31, 2018
Copy link
Contributor

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jacobheun jacobheun merged commit 40e840d into master Oct 31, 2018
@jacobheun jacobheun deleted the feat/add-datastore-to-config branch October 31, 2018 13:43
@ghost ghost removed the status/in-progress In progress label Oct 31, 2018
maschad pushed a commit to maschad/js-libp2p that referenced this pull request Jun 21, 2023
`any-signal` can now remove the event listeners it installs preventing
a source of memory leaks.
maschad pushed a commit to maschad/js-libp2p that referenced this pull request Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants