feat: add capability detection to metrics-devtools #2708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the ability to find configured services that possess a given capability and interact with that service via rpc. Starts with a configured PubSub service.
wemeetagain
reviewed
Sep 19, 2024
| @@ -257,6 +262,13 @@ class DevToolsMetrics implements Metrics, Startable { | |||
| .catch(err => { | |||
| this.log.error('error while reading RPC messages', err) | |||
| }) | |||
|
|
|||
| const pubsub = findCapability('@libp2p/pubsub', this.components) | |||
There was a problem hiding this comment.
can you use getPubsub here?
There was a problem hiding this comment.
No, because you need to know the name of the pubsub component ahead of time to use getPubsub
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the ability to find configured services that possess a given capability and interact with that service via rpc.
Starts with a configured PubSub service.
Change checklist