feat: Use CIDR format for connection-manager allow/deny lists #2783
+33
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@SgtPooki @wemeetagain @dhuseby
Description
This PR updates the connection manager to treat multiaddrs in the allow/deny lists using the standard IP CIDR format (e.g.
/ip4/52.55.0.0/ipcidr/16
) rather than string prefixes (e.g./ip4/52.55
). This allows us to validate multiaddrs accurately and ensures better control over IP address matching.Changes:
.allow
and.deny
properties in the connection manager to useIpNet[]
for IP range validation.IpNet
format for both allow and deny lists.Relevant issues:
Notes & open questions
IpNet
format to ensure the connection manager handles IPs in CIDR notation.Change checklist