Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only update pending incoming connections if connection accepted #2790

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

achingbrain
Copy link
Member

The afterUpgradeInbound function decrements the count of pending (e.g. not upgraded yet) incoming connections, so only invoke that method if we actually accepted the connection, otherwise we decrement a counter that was never incremented.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

The `afterUpgradeInbound` function decrements the count of pending
(e.g. not upgraded yet) incoming connections, so only invoke that
method if we actually accepted the connection, otherwise we decrement
a counter that was never incremented.
@achingbrain achingbrain requested a review from a team as a code owner October 26, 2024 10:42
@achingbrain achingbrain merged commit d34642d into main Oct 28, 2024
30 checks passed
@achingbrain achingbrain deleted the fix/only-update-pending-incoming-if-accepted branch October 28, 2024 08:07
@achingbrain achingbrain mentioned this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants