Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validate dht config #286

Closed
wants to merge 1 commit into from
Closed

Conversation

vasco-santos
Copy link
Member

In the context of the issue reported ipfs/js-ipfs#1657#issuecomment-440758206

@ghost ghost assigned vasco-santos Nov 23, 2018
@ghost ghost added the status/in-progress In progress label Nov 23, 2018
Copy link
Contributor

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vasco-santos i think we should just fix the defaults in the config file. When the validator runs it will automatically add them so we don't hit this issue. I think it's a simpler change. I pushed a quick commit with a test to show what I mean: 9abb0c0

@vasco-santos
Copy link
Member Author

Yes, your solution sounds way better. Can you create the PR with it?

@jacobheun jacobheun mentioned this pull request Nov 29, 2018
@jacobheun
Copy link
Contributor

Closing in favor of #289

@jacobheun jacobheun closed this Nov 29, 2018
@ghost ghost removed the status/in-progress In progress label Nov 29, 2018
@jacobheun jacobheun deleted the fix/validate-dht-config branch November 29, 2018 12:28
maschad pushed a commit to maschad/js-libp2p that referenced this pull request Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants