fix: add DER decoder and allow passing protobuf digest #3013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds enough of a DER decoder to parse public keys from PKIX bytes. Also allows passing the digest of a public key in to `publicKeyFromProtobuf` so we can avoid having to recalculate it. This becomes a big bottleneck when loading a routing table's worth of peers from the peer store where many of them are RSA peers.
achingbrain
added a commit
that referenced
this pull request
Feb 26, 2025
This with the changes from #3013 roughly doubles the throughput of loading RSA peers from the peer store which is a massive bottleneck when restarting the amino bootstrapper. Before: ``` % node benchmarks/load-peers.js read all x 5.94 ops/sec ±1.37% (33 runs sampled) ``` After: ``` % node benchmarks/load-peers.js read all x 12.43 ops/sec ±1.18% (63 runs sampled) ```
achingbrain
added a commit
that referenced
this pull request
Feb 26, 2025
This with the changes from #3013 roughly doubles the throughput of loading RSA peers from the peer store which is a massive bottleneck when restarting the amino bootstrapper. Before: ``` % node benchmarks/load-peers.js read all x 5.94 ops/sec ±1.37% (33 runs sampled) ``` After: ``` % node benchmarks/load-peers.js read all x 12.43 ops/sec ±1.18% (63 runs sampled) ```
3 tasks
Merged
achingbrain
added a commit
that referenced
this pull request
Feb 27, 2025
This with the changes from #3013 roughly doubles the throughput of loading RSA peers from the peer store which is a massive bottleneck when restarting the amino bootstrapper. Before: ``` % node benchmarks/load-peers.js read all x 5.94 ops/sec ±1.37% (33 runs sampled) ``` After: ``` % node benchmarks/load-peers.js read all x 12.43 ops/sec ±1.18% (63 runs sampled) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds enough of a DER decoder/encoder to parse/store public keys from PKIX bytes and private keys in PKCS#1 bytes.
Also allows passing the digest of a public key in to
publicKeyFromProtobufso we can avoid having to recalculate it.This becomes a big bottleneck when loading a routing table's worth of peers from the peer store where many of them are RSA peers.
Change checklist