Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows testing is back!! #335

Merged
merged 1 commit into from
Mar 12, 2019
Merged

Windows testing is back!! #335

merged 1 commit into from
Mar 12, 2019

Conversation

hugomrdias
Copy link
Member

@hugomrdias hugomrdias commented Mar 12, 2019 •
edited
Loading

chore: remove npmignore because we have files prop in package.json

no need to merge this PR its just to trigger the windows ci

@ghost ghost assigned hugomrdias Mar 12, 2019
@ghost ghost added the status/in-progress In progress label Mar 12, 2019
vasco-santos
vasco-santos approved these changes Mar 12, 2019
View reviewed changes
Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

jacobheun
jacobheun approved these changes Mar 12, 2019
View reviewed changes
Copy link
Contributor

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Going to merge this since we don't need the npmignore file.

@jacobheun jacobheun merged commit 282ce62 into master Mar 12, 2019
@ghost ghost removed the status/in-progress In progress label Mar 12, 2019
@jacobheun jacobheun deleted the chore/windows-tests branch March 12, 2019 17:19
@jacobheun jacobheun mentioned this pull request Mar 12, 2019
Closed
@snyk-bot snyk-bot mentioned this pull request Jan 21, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Mar 21, 2022
Open
@adamlaska adamlaska mentioned this pull request Feb 20, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Apr 25, 2023
Open
@adamlaska adamlaska mentioned this pull request May 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobheun jacobheun jacobheun approved these changes

@vasco-santos vasco-santos vasco-santos approved these changes

Assignees

@hugomrdias hugomrdias

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hugomrdias @jacobheun @vasco-santos