Instantiate transports with a reference to node #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobheun
reviewed
May 17, 2019
src/index.js
Outdated
| @@ -345,7 +345,7 @@ class Node extends EventEmitter { | |||
| let t | |||
|
|
|||
| if (typeof Transport === 'function') { | |||
| t = new Transport() | |||
| t = new Transport({libp2p: this}) | |||
There was a problem hiding this comment.
Linting fix:
Suggested change
| t = new Transport({libp2p: this}) | |
| t = new Transport({ libp2p: this }) |
There was a problem hiding this comment.
Other than the linting issue this looks fine. Travis is failing due to this and commitlint. I went ahead and disabled commitlint on master so it doesn't block tests going forward. If you rebase master and fix the linting issue I suggested above, travis tests should properly run.
I'll update the commit message on squash/merge.
+bundlesize: { maxSize: '222kB' },
-bundlesize: { maxSize: '218kB' },? |
jacobheun
approved these changes
May 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed here, transports could benefit from having a reference to the libp2p node on creation (in case the transport depends on perior connections, e.g. webrtc, relay).
As far as I can tell, this change is backwards compatible.