Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate Typescript Typings via JsDoc #449

Closed
wants to merge 3 commits into from
Closed

Generate Typescript Typings via JsDoc #449

wants to merge 3 commits into from

Conversation

samparsky
Copy link

Generates Typescript Typings via JsDoc

  • Adds typings to the js-libp2p module
  • Add typings generation to travis.yml
  • Include typings test

@samparsky samparsky changed the title Add typescript typings Generate Typescript Typings via JsDoc Aug 25, 2019
@samparsky samparsky mentioned this pull request Aug 25, 2019
Open
@mpetrunic
Copy link
Member

I don't think this is gonna work, you are using types like PeerInfo and PeerId that are not linked here (should be created in their own repos first)

@vasco-santos
Copy link
Member

FYI: we are moving on this way for the support for typescript users. Thanks to aegir that now supports typescript definitions from the jsdocs

@vasco-santos
Copy link
Member

Closing this as we shipped 0.30 with typedefs generated on release. Thanks anyway for the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sahilpohare sahilpohare sahilpohare approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samparsky @mpetrunic @vasco-santos @sahilpohare