Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add streaming iterables guide #459

Merged
merged 3 commits into from
Sep 30, 2019

Conversation

jacobheun
Copy link
Contributor

The usage section is currently blank, but I think getting this in sooner is best so that anyone can iterate on this. I am aiming to get some examples added in the next couple days.

I also moved the peer discovery readme since there is now a sub directory for docs.

Note: This is going into the async refactor branch

@@ -0,0 +1,32 @@
# Iterable Streams

> This document is a guide on how to use Iterable Streams in Libp2p. As a part of the refactor away from callbacks, we have also moved to using Iterable Streams instead of [pull-streams](https://pull-stream.github.io/). If there are missing usage guides you feel should be added, please submit a PR!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we point the Issue here for context?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 done!

@jacobheun jacobheun merged commit c1da30b into refactor/async-await Sep 30, 2019
@jacobheun jacobheun deleted the docs/streaming-iterables branch September 30, 2019 16:20
dirkmc pushed a commit that referenced this pull request Nov 26, 2019
* docs: add streaming iterables guide placeholder

* chore: move peer discovery readme to doc fold:wqer

* docs: add link to async refactor issue
dirkmc pushed a commit that referenced this pull request Nov 26, 2019
* docs: add streaming iterables guide placeholder

* chore: move peer discovery readme to doc fold:wqer

* docs: add link to async refactor issue
jacobheun added a commit that referenced this pull request Dec 12, 2019
* docs: add streaming iterables guide placeholder

* chore: move peer discovery readme to doc fold:wqer

* docs: add link to async refactor issue
jacobheun added a commit that referenced this pull request Jan 24, 2020
* docs: add streaming iterables guide placeholder

* chore: move peer discovery readme to doc fold:wqer

* docs: add link to async refactor issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants