refactor: circuit relay to async #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobheun
changed the title
jacobheun
force-pushed
the
refactor/circuit
branch
from
48857ad
to
08cb39d
Compare
jacobheun
changed the title
vasco-santos
suggested changes
Nov 28, 2019
There was a problem hiding this comment.
Great work @jacobheun
Found smaller stuff, but this should be almost ready to go
| */ | ||
| getRawConn () { | ||
| return this.conn | ||
| return this.stream |
There was a problem hiding this comment.
Can we leverage this to better name this function?
There was a problem hiding this comment.
It's not being used anywhere so I will just remove it.
jacobheun
force-pushed
the
refactor/circuit
branch
from
fc045c0
to
6fd7d0e
Compare
jacobheun
force-pushed
the
refactor/circuit
branch
from
6fd7d0e
to
5b2386d
Compare
|
I switched tests over to use chai-as-promised to get better visibility into test failures, and then fixed an issue with needing to reset the multiaddrs of the test nodes for the relay suite due to the fix in #485 |
jacobheun
added a commit
that referenced
this pull request
Dec 12, 2019
* refactor: add dialing over relay support * chore: fix lint * fix: dont clear listeners on close * fix: if dial errors already have codes, just rethrow them * fix: clear the registrar when libp2p stops * fix: improve connection maintenance with circuit * chore: correct feedback * test: use chai as promised * test(fix): reset multiaddrs on dial test
jacobheun
added a commit
that referenced
this pull request
Jan 24, 2020
* refactor: add dialing over relay support * chore: fix lint * fix: dont clear listeners on close * fix: if dial errors already have codes, just rethrow them * fix: clear the registrar when libp2p stops * fix: improve connection maintenance with circuit * chore: correct feedback * test: use chai as promised * test(fix): reset multiaddrs on dial test
maschad
pushed a commit
to maschad/js-libp2p
that referenced
this pull request
Jun 21, 2023
This dep is used, unsure why dep-check says it isn't.
maschad
pushed a commit
to maschad/js-libp2p
that referenced
this pull request
Jun 21, 2023
## [9.3.4](libp2p/js-libp2p-kad-dht@v9.3.3...v9.3.4) (2023-05-22) ### Bug Fixes * add events dep ([libp2p#477](libp2p/js-libp2p-kad-dht#477)) ([3744a20](libp2p/js-libp2p-kad-dht@3744a20))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relay
/p2p-circuit/<relay multiaddr>/p2p/<relay peer id>will cause the node to dial that relay.Note: This does not include active relay dialing (Relays wont dial unconnected destination peers). However, this is a low priority. In most instances we shouldn't try dialing a peer we're not connected to, because this means the dialing peer should also be able to connect to them. The only instance this is not the case, is if the relay is in a private network with the destination node and is the only exposed node. Private networks should be explicitly connecting to their exposed relay in this instance.
Other fixes
closemethod which is called onlibp2p.stop().