refactor: core async #478
Merged
refactor: core async #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test: auto dial on startup
vasco-santos
suggested changes
Nov 19, 2019
Co-Authored-By: Vasco Santos <vasco.santos@moxy.studio>
vasco-santos
added a commit
that referenced
this pull request
Nov 21, 2019
* refactor: cleanup core test: auto dial on startup * fix: make hangup work properly * chore: fix lint * chore: apply suggestions from code review Co-Authored-By: Vasco Santos <vasco.santos@moxy.studio>
vasco-santos
added a commit
that referenced
this pull request
Nov 21, 2019
* refactor: cleanup core test: auto dial on startup * fix: make hangup work properly * chore: fix lint * chore: apply suggestions from code review Co-Authored-By: Vasco Santos <vasco.santos@moxy.studio>
vasco-santos
added a commit
that referenced
this pull request
Nov 21, 2019
* refactor: cleanup core test: auto dial on startup * fix: make hangup work properly * chore: fix lint * chore: apply suggestions from code review Co-Authored-By: Vasco Santos <vasco.santos@moxy.studio>
dirkmc
pushed a commit
that referenced
this pull request
Nov 26, 2019
* refactor: cleanup core test: auto dial on startup * fix: make hangup work properly * chore: fix lint * chore: apply suggestions from code review Co-Authored-By: Vasco Santos <vasco.santos@moxy.studio>
dirkmc
pushed a commit
that referenced
this pull request
Nov 26, 2019
* refactor: cleanup core test: auto dial on startup * fix: make hangup work properly * chore: fix lint * chore: apply suggestions from code review Co-Authored-By: Vasco Santos <vasco.santos@moxy.studio>
jacobheun
pushed a commit
that referenced
this pull request
Nov 26, 2019
* refactor: core async (#478) * refactor: cleanup core test: auto dial on startup * fix: make hangup work properly * chore: fix lint * chore: apply suggestions from code review Co-Authored-By: Vasco Santos <vasco.santos@moxy.studio> * fix: provide libp2p dialer to the dht * chore: use dht release
jacobheun
added a commit
that referenced
this pull request
Dec 12, 2019
* refactor: cleanup core test: auto dial on startup * fix: make hangup work properly * chore: fix lint * chore: apply suggestions from code review Co-Authored-By: Vasco Santos <vasco.santos@moxy.studio>
jacobheun
pushed a commit
that referenced
this pull request
Dec 12, 2019
* refactor: core async (#478) * refactor: cleanup core test: auto dial on startup * fix: make hangup work properly * chore: fix lint * chore: apply suggestions from code review Co-Authored-By: Vasco Santos <vasco.santos@moxy.studio> * fix: provide libp2p dialer to the dht * chore: use dht release
jacobheun
added a commit
that referenced
this pull request
Jan 24, 2020
* refactor: cleanup core test: auto dial on startup * fix: make hangup work properly * chore: fix lint * chore: apply suggestions from code review Co-Authored-By: Vasco Santos <vasco.santos@moxy.studio>
jacobheun
pushed a commit
that referenced
this pull request
Jan 24, 2020
* refactor: core async (#478) * refactor: cleanup core test: auto dial on startup * fix: make hangup work properly * chore: fix lint * chore: apply suggestions from code review Co-Authored-By: Vasco Santos <vasco.santos@moxy.studio> * fix: provide libp2p dialer to the dht * chore: use dht release
maschad
pushed a commit
to maschad/js-libp2p
that referenced
this pull request
Jun 21, 2023
Instead of debouncing and using timeouts to wait for DHT peers before running the initial self-query, instead get the routing table to emit events when peers are added or removed - if the table is empty when we run the self-query, wait for the `peer:add` event before continuing. Improves startup time. Adds tests for the query-self component.
maschad
pushed a commit
to maschad/js-libp2p
that referenced
this pull request
Jun 21, 2023
## [9.3.5](libp2p/js-libp2p-kad-dht@v9.3.4...v9.3.5) (2023-05-26) ### Bug Fixes * use events to delay before self-query ([libp2p#478](libp2p/js-libp2p-kad-dht#478)) ([46313a8](libp2p/js-libp2p-kad-dht@46313a8)) ### Dependencies * **dev:** bump delay from 5.0.0 to 6.0.0 ([libp2p#476](libp2p/js-libp2p-kad-dht#476)) ([50524f9](libp2p/js-libp2p-kad-dht@50524f9))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up a few things in the main libp2p file for async.
hangUpnow correctly interacts with the registrar to close connectionshangUpnow only accepts a PeerId to simplify the api