Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

async await version of examples/echo #483

Merged
merged 8 commits into from
Nov 27, 2019

Conversation

dirkmc
Copy link
Contributor

@dirkmc dirkmc commented Nov 25, 2019

Note: depends on

@dirkmc dirkmc changed the base branch from master to refactor/async-await November 25, 2019 22:55
@dirkmc dirkmc force-pushed the fix/examples-echo branch 2 times, most recently from 131cf6a to 7bd8e29 Compare November 26, 2019 15:11
@jacobheun
Copy link
Contributor

#480 has been merged!

Copy link
Contributor

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should clean up the echo libp2p bundle to its minimum configuration. I think it's overly complex right now. Here's what I am thinking for the whole file:

'use strict'

const TCP = require('libp2p-tcp')
const WS = require('libp2p-websockets')
const mplex = require('libp2p-mplex')
const secio = require('libp2p-secio')
const defaultsDeep = require('@nodeutils/defaults-deep')
const libp2p = require('../../..')

class Node extends libp2p {
  constructor (_options) {
    const defaults = {
      modules: {
        transport: [
          TCP,
          WS
        ],
        streamMuxer: [ mplex ],
        connEncryption: [ secio ]
      }
    }

    super(defaultsDeep(_options, defaults))
  }
}

module.exports = Node

@dirkmc
Copy link
Contributor Author

dirkmc commented Nov 26, 2019

Agreed 👍

I made that change

betamos and others added 8 commits November 26, 2019 16:53
Array.shift seems to be very slow, perhaps linear, on some
engines, resulting in  _update consuming a lot of CPU.
* docs(fix): correct docs and example for pnet

* docs(fix): correct pnet docs
`ipfs.files.cat` is incorrect. the correct function is `ipfs.cat`
Copy link
Contributor

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jacobheun jacobheun merged commit 3fc352c into refactor/async-await Nov 27, 2019
@jacobheun jacobheun deleted the fix/examples-echo branch November 27, 2019 11:24
jacobheun pushed a commit that referenced this pull request Dec 12, 2019
* fix: performance bottleneck in stat.js (#463)

Array.shift seems to be very slow, perhaps linear, on some
engines, resulting in  _update consuming a lot of CPU.

* docs(fix): correct docs and example for pnet (#464)

* docs(fix): correct docs and example for pnet

* docs(fix): correct pnet docs

* docs(fix): update README.md language (#468)

* docs: reciprocate (#474)

* docs(example): fix ipfs cat (#475)

`ipfs.files.cat` is incorrect. the correct function is `ipfs.cat`

* fix: async await examples/echo

* fix: examples readme typos (#481)

* fix: simplify libp2p bundle for echo example
jacobheun pushed a commit that referenced this pull request Jan 24, 2020
* fix: performance bottleneck in stat.js (#463)

Array.shift seems to be very slow, perhaps linear, on some
engines, resulting in  _update consuming a lot of CPU.

* docs(fix): correct docs and example for pnet (#464)

* docs(fix): correct docs and example for pnet

* docs(fix): correct pnet docs

* docs(fix): update README.md language (#468)

* docs: reciprocate (#474)

* docs(example): fix ipfs cat (#475)

`ipfs.files.cat` is incorrect. the correct function is `ipfs.cat`

* fix: async await examples/echo

* fix: examples readme typos (#481)

* fix: simplify libp2p bundle for echo example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants