refactor: examples/discovery-mechanisms #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
changed the title
vasco-santos
force-pushed
the
refactor/examples-discovery-mechanisms
branch
from
1f004e3 to
07f0e97
Compare
jacobheun
force-pushed
the
refactor/async-await
branch
from
374ceb4 to
45f4702
Compare
vasco-santos
force-pushed
the
refactor/examples-discovery-mechanisms
branch
from
07f0e97 to
cc46973
Compare
vasco-santos
force-pushed
the
refactor/examples-discovery-mechanisms
branch
from
cc46973 to
980ae89
Compare
vasco-santos
requested review from
jacobheun
and removed request for
jacobheun
jacobheun
reviewed
Dec 16, 2019
| }, | ||
| config: { | ||
| peerDiscovery: { | ||
| bootstrap: { |
There was a problem hiding this comment.
This needs to be the mdns config, it's using bootstrap.
| // picking any protocol) in order to get a full Connection. The Peer Discovery | ||
| // doesn't make any decisions for you. | ||
| node.dial(peer, () => {}) | ||
| }) |
There was a problem hiding this comment.
autoDial is true by default, we should remove this block.
| }) | ||
| node.start(cb) | ||
| const peerInfo = await PeerInfo.create() | ||
| peerInfo.multiaddrs.add('/ip4/0.0.0.0/tcp/0') |
There was a problem hiding this comment.
We could let Libp2p.create create the PeerInfo and then just do libp2p.peerInfo.multiaddrs.add('/ip4/0.0.0.0/tcp/0') after we create the node.
examples/discovery-mechanisms/1.js
Outdated
| } | ||
| ;(async () => { | ||
| const peerInfo = await PeerInfo.create() | ||
| peerInfo.multiaddrs.add('/ip4/0.0.0.0/tcp/0') |
There was a problem hiding this comment.
Same here as below, let Libp2p.create make the PeerInfo.
vasco-santos
force-pushed
the
refactor/examples-discovery-mechanisms
branch
from
8b729b5 to
609bd10
Compare
Co-Authored-By: Jacob Heun <jacobheun@gmail.com>
vasco-santos
force-pushed
the
refactor/examples-discovery-mechanisms
branch
from
609bd10 to
0535ecf
Compare
jacobheun
approved these changes
Jan 2, 2020
| // Once the dial is complete, this event is emitted. | ||
| node.on('peer:connect', (peer) => { | ||
| console.log('Connection established to:', peer.id.toB58String()) | ||
| }) |
There was a problem hiding this comment.
We should add the peer:connect event listener back, I think it got accidentally removed.
There was a problem hiding this comment.
I thought you suggested to remove it because of being kind of redundant, since should dial is true by default libp2p/js-libp2p#498/files#r358312128. But yeah, let's put it back, I also think we can double check this
Co-Authored-By: Jacob Heun <jacobheun@gmail.com>
jacobheun
added a commit
that referenced
this pull request
Jan 24, 2020
* refactor: examples-discovery-mechanisms * chore: apply suggestions from code review Co-Authored-By: Jacob Heun <jacobheun@gmail.com> * chore: suggestion interval Co-Authored-By: Jacob Heun <jacobheun@gmail.com> * chore: add peer connected event Co-authored-by: Jacob Heun <jacobheun@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
discovery-mechanismsexample to the refactored asyncjs-libp2p.Needs: