refactor: examples/peer-and-content-routing #500
Merged
+110
−169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
force-pushed
the
refactor/examples-peer-and-content-routing
branch
from
a01363b
to
aa87ade
Compare
jacobheun
force-pushed
the
refactor/async-await
branch
from
374ceb4
to
45f4702
Compare
vasco-santos
force-pushed
the
refactor/examples-peer-and-content-routing
branch
from
aa87ade
to
12cc970
Compare
vasco-santos
requested review from
jacobheun
and removed request for
jacobheun
jacobheun
reviewed
Dec 16, 2019
| dht: { | ||
| // dht must be enabled | ||
| enabled: true, | ||
| kBucketSize: 20 |
There was a problem hiding this comment.
We don't use kBucketSize in the code, we should probably just leave it out here. Most users won't need to change the default.
|
|
||
| console.log('Node %s is providing %s', node1.peerInfo.id.toB58String(), cid.toBaseEncodedString()) |
There was a problem hiding this comment.
Was this removed intentionally? If so, it should also be removed from the readme. Can you make sure the code in the readme matches what's in the js files
There was a problem hiding this comment.
I added it back, I removed unintentionally
Co-Authored-By: Jacob Heun <jacobheun@gmail.com>
jacobheun
added a commit
that referenced
this pull request
Jan 24, 2020
* refactor: examples-peer-and-content-routing * chore: address review * chore: review suggestions Co-Authored-By: Jacob Heun <jacobheun@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
peer-and-content-routingexample to the refactored asyncjs-libp2p.Needs: