Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: examples pubsub #504

Merged
merged 1 commit into from
Dec 16, 2019
Merged

refactor: examples pubsub #504

merged 1 commit into from
Dec 16, 2019

Conversation

vasco-santos
Copy link
Member

@vasco-santos vasco-santos commented Dec 10, 2019 •
edited
Loading

This PR refactors the pubsub example to the refactored async js-libp2p.

Needs:

jacobheun
jacobheun approved these changes Dec 16, 2019
View reviewed changes
Copy link
Contributor

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much cleaner! LGTM

@jacobheun jacobheun merged commit 9f0f08f into refactor/async-await Dec 16, 2019
@jacobheun jacobheun deleted the refactor/examples-pubsub branch December 16, 2019 22:28
jacobheun pushed a commit that referenced this pull request Jan 24, 2020
@vasco-santos @jacobheun
refactor: examples-pubsub (#504)
b08d81c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobheun jacobheun jacobheun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vasco-santos @jacobheun