fix: remove node global #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56 tasks
jacobheun
reviewed
Apr 14, 2020
| @@ -0,0 +1,242 @@ | |||
| 'use strict' | |||
There was a problem hiding this comment.
The latency monitor was pulled from the npm package right? Can we get attribution added, I'm not seeing it anywhere.
- adds buffer require - adds globalThis where needed - streaming-iterables was remove and new utils created, this will be consolidated in `ipfs-utils` and backported here to normalize all these iterator helper functions - latency-monitor was copied inside the repo - iso-random-stream is now used instead of node crypto - the test `should ignore self on discovery` was moved to node only Size: 172.97KB 47.03KB below the 220KB limit. `aegir build --node false` and `aegir test -t browser --node false` now work 🎉
hugomrdias
force-pushed
the
fix/remove-node-globals
branch
from
5e38009 to
3422f64
Compare
|
Released in v0.27.7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ipfs-utilsand backported here to normalize all these iterator helper functionsshould ignore self on discoverywas moved to node onlySize: 172.97KB
47.03KB below the 220KB limit.
aegir build --node falseandaegir test -t browser --node falsenow work 🎉related to this ipfs/js-ipfs#2924