chore: integrate libp2p-keychain into js-libp2p (#633) #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
force-pushed
the
feat/libp2p-keychain
branch
2 times, most recently
from
8128e6f
to
f8a80e8
Compare
vasco-santos
commented
May 13, 2020
| 'use strict' | ||
|
|
||
| module.exports = require('./keychain') |
There was a problem hiding this comment.
content of src/keychain/keychain was moved here to be consistent with the rest of the libp2p codebase
vasco-santos
force-pushed
the
feat/libp2p-keychain
branch
from
f8a80e8
to
a275c78
Compare
Integrates the libp2p-keychain codebase into this repo
vasco-santos
force-pushed
the
feat/libp2p-keychain
branch
from
a275c78
to
303bbee
Compare
jacobheun
reviewed
May 13, 2020
src/config.js
Outdated
| @@ -17,6 +18,9 @@ const DefaultConfig = { | |||
| maxDialsPerPeer: Constants.MAX_PER_PEER_DIALS, | |||
| dialTimeout: Constants.DIAL_TIMEOUT | |||
| }, | |||
| keychain: { | |||
| datastore: new MemoryDatastore() | |||
| }, | |||
There was a problem hiding this comment.
This is going to cause us to carry around the MemoryDatastore even if we don't use the keychain. I think we should just default this to null and check the datastore before creating the keychain. There's no real value in a memory datastore for the keychain.
There was a problem hiding this comment.
you are right! just removed it and added a validation. In the docs it is already defined as required
Co-authored-by: Jacob Heun <jacobheun@gmail.com>
vasco-santos
force-pushed
the
feat/libp2p-keychain
branch
from
dbd3d4f
to
84f1e30
Compare
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrates the libp2p-keychain codebase into libp2p.keychain.
This is the second part of decoupling #631 and replaces it.