fix: replace node buffers with uint8arrays #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achingbrain
requested review from
jacobheun and
vasco-santos
and removed request for
jacobheun
64 tasks
|
This is using a temporary fork of libp2p-noise that has the changes from ChainSafe/js-libp2p-noise#70 applied and the typescript compiled to js. |
|
Looks like the browser tests are failing |
vasco-santos
suggested changes
Aug 14, 2020
|
I am going to change the base of this to the 0.29.x branch so I can update the new signed peer records work. I'd like to land these together in 0.29 |
Upgrades all deps and replaces all use of node Buffers with Uint8Arrays BREAKING CHANGES: - All deps used by this module now use Uint8Arrays in place of node Buffers
jacobheun
force-pushed
the
fix/replace-node-buffers-with-uint8arrays
branch
from
fbeecde
to
2143508
Compare
|
With libp2p/js-libp2p-interfaces#62 this should be good to go for the 0.29 branch. |
vasco-santos
approved these changes
Aug 24, 2020
|
Ci is failing due to interop, this is a release order issue with the daemon. We can resolve this before release. |
jacobheun
added a commit
that referenced
this pull request
Aug 27, 2020
* fix: replace node buffers with uint8arrays Upgrades all deps and replaces all use of node Buffers with Uint8Arrays BREAKING CHANGES: - All deps used by this module now use Uint8Arrays in place of node Buffers * chore: browser fixes * chore: remove .only * chore: stringify uint8array before parsing * chore: update interop suite * chore: remove ts from build command * chore: update deps * fix: update records to use uint8array * chore: fix lint * chore: update deps Co-authored-by: Jacob Heun <jacobheun@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades all deps and replaces all use of node Buffers with Uint8Arrays
Depends on:
BREAKING CHANGES: