-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds typescript types + type tests #110
Conversation
Signed-off-by: Carson Farmer <carson.farmer@gmail.com>
Keeping this as a draft for now, until multiformats/js-cid#102 is (hopefully merged and) released (tho this PR is already useful as is). If you'd rather not have these types in this repo, please let me know @vasco-santos, and I can PR them to definitelytyped instead. |
See libp2p/js-libp2p-crypto#161 for a discussion of the possible applications of these types for CI etc. |
Signed-off-by: Carson Farmer <carson.farmer@gmail.com>
Type checking/tests could be added to CI by adding:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Btw, I see we're adding the types to the repository itself. So, if you want to move the js-multicoded
to its repository, please feel free to PR and ping me 😄
Awesome, any chance we could get a patch release once this is merged 🙏? P.S. I will indeed ping you if/when I get a chance to update |
@carsonfarmer thanks. Pinging @vasco-santos since I don't have publish permissions here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Released in 0.13.7. |
Depends on multiformats/js-cid#102 for tests to run/work nicely, but this PR is already useful on its own if you don't want to use the tests in CI etc.