This repository has been archived by the owner on Feb 26, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As dive into ipfs / libp2p code base I struggle to guess what are all the things passed around. Types as in flow (or typescript for that matter) simplify learning of how things are connected significantly. There for I decided to contribute type signatures to the code base as I digg through it.
What's up with all these .js.flow files ?
Unfortunately flow project has yet to come up with coherent story of how to provide type annotations for third party libraries. In my experience adding
.js.flow
files works best out of all options, that is because flow type checker when gives a precedent to/path/to/file.js.flow
over/path/to/file.js
which essentially provides a way to provide type annotations for non-flow typed package such that just using it as dependency will satisfy both type checker and run-time.It's far from ideal given that
.js
and.js.flow
files can get out of sync but then again unless you're open to adopt flow this is the best option IMO.Depends on libp2p/js-peer-id#75