Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/external: Use rust-libp2p spec compliant X25519Spec #260

Closed
mxinden opened this issue Dec 19, 2022 · 2 comments · Fixed by #261
Closed

test/external: Use rust-libp2p spec compliant X25519Spec #260

mxinden opened this issue Dec 19, 2022 · 2 comments · Fixed by #261

Comments

@mxinden
Copy link
Member

mxinden commented Dec 19, 2022

use libp2p::noise::{Keypair, X25519, NoiseConfig};

We are deprecating X25519, please use X25519Spec instead.

See libp2p/rust-libp2p#3227.

@ajsutton
Copy link
Contributor

hmm, I didn't even know that was there. Those interop tests haven't been running in CI so haven't been maintained and don't seem to be even compiling for the most part. I've put up a PR to remove them since they don't provide any value if we aren't running them anyway and a simple ping isn't a particularly good compatibility test anyway.

@mxinden
Copy link
Member Author

mxinden commented Dec 30, 2022

Thanks @ajsutton for the quick response and follow-up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants