Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the interop tests #261

Merged
merged 2 commits into from
Dec 20, 2022
Merged

Conversation

ajsutton
Copy link
Contributor

@ajsutton ajsutton commented Dec 19, 2022

They weren't running in CI and haven't been maintained so the other language client no longer even compile cleanly. Given we're not running these tests and they were only basic ping, they aren't providing enough value to justify fixing and maintaining them.

fixes #260

They weren't running in CI and haven't been maintained so the other language client no longer even compile cleanly. Given we're not running these tests and they were only basic ping, they aren't providing enough value to justify fixing and maintaining them.
Copy link
Collaborator

@Nashatyrev Nashatyrev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let's remove them for now. Especially assuming they are not compiled any more.
In case we want them back they are always in the git history

I believe we should also remove ServerInterOpTest and ClientInterOpTest then

@ajsutton ajsutton merged commit cafa8a0 into libp2p:develop Dec 20, 2022
@ajsutton ajsutton deleted the remove-interop-tests branch December 20, 2022 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test/external: Use rust-libp2p spec compliant X25519Spec
2 participants