Refactor GossipRouter: extract GossipRouterBuilder #249
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is follow up to #247
In the very initial version I've made an attempt to invent a new Kotlin specific pattern which combines both builder and its resulting class entities. It should in theory make the code smaller and supporting efforts cheaper.
But it finally failed to be both a builder pattern and any kind of sustainable code. With
GossipRouter
becoming more complex class that approach is turning into error-prone spaghetti code.This PR extracts
GossipRouterBuilder
with makingGossipRouter
properties final (where appropriate), which looks more like a traditional pattern for Teku code and should be less error-prone and more sustainableAlso:
AbstractRouter.addPeerWithDebugHandler()
workaroundvar
properties