Fix scenario where a call to getPeerHandler would always throw
#254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix an issue where `stream.getPeerHandler` is called even when steam is closed on initialization, which would always throw due to `peerHandler` not being set
jimmygchen
changed the title
getPeerHandler would always throw
Nashatyrev
approved these changes
Aug 19, 2022
|
The regression was introduced with #247 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix an issue where
stream.getPeerHandleris called even when steam is closed on initialization, which would always throw due topeerHandlernot being set, as documented inP2PService.closeAbruptlyAvoiding the
stream.getPeerHandlercall in the case wherestream.aborted == trueshould prevent this error.Issue raised in Teku:
Consensys/teku#6088
ps. I'm not familiar with the code base at all - so my investigation and guess may well be incorrect. I'm looking for a way to test this - any suggestions / ideas on how to do this is appreciated!